talk recording - prefer local installation #3569
Conversation
Signed-off-by: Simon L <[email protected]>
| @@ -30,7 +30,7 @@ RUN set -ex; \ | |||
| echo "root:$(openssl rand -base64 12)" | chpasswd; \ | |||
| git clone --recursive https://github.com/nextcloud/spreed --depth=1 --single-branch --branch "$RECORDING_VERSION" /src; \ | |||
| mv -v /src/recording/pyproject.toml /src/recording/src/pyproject.toml; \ | |||
| python3 -m pip install --no-cache-dir /src/recording/src; \ | |||
| python3 -m pip install --no-cache-dir --no-index --find-links=file:///local/dir /src/recording/src; \ | |||
There was a problem hiding this comment.
I guess I need to adjust file:///local/dir ? question is to what but I suppose that is what I need to figure out myself 😅
There was a problem hiding this comment.
Speaking of which, the recording backend was moved to it's own repo:
https://github.com/nextcloud/nextcloud-talk-recording
There was a problem hiding this comment.
right, thanks for the heads-up!
There was a problem hiding this comment.
Actuallly we are installing the packages from the pyproject file so I am not sure we actually need the above code changes here? also https://github.com/nextcloud-releases/all-in-one/actions/runs/6563947941/job/17832323096 seems to show that. @danxuliu please clarify :)
Also see https://github.com/nextcloud/nextcloud-talk-recording/blob/main/pyproject.toml
There was a problem hiding this comment.
Using --no-index disables getting the packages from PyPi. However, it does it not only for the package being installed, but also its dependencies.
However, to locally install a package it is enough to use an identifier that hints at being a local directory. So installing from /src/recording/src* should be fine; to err on the side of caution you could prepend file://, but it should not be necessary.
The problem in the recording server documentation was that it was installed from a relative directory named nextcloud-talk-recording, so pip tried to fetch it from PyPi too.
*Out of curiosity, why do you move the pyproject.toml file inside the src directory? It should be enough to keep it in the original place and install /src/recording, or what am I missing? :-)
szaimen
changed the title
|
I guess I can close this? |
No description provided.