-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimisations of the reverse proxy and docker rootless docs #3492
optimisations of the reverse proxy and docker rootless docs #3492
Conversation
Signed-off-by: Marvin von Papen <[email protected]>
Running a proxy manager directly on the host or in a container leads to different adaption of the example configurations. The description for this is simplified and more structured now. Additional the steps are written once and referenced per example configuration. Signed-off-by: Marvin von Papen <[email protected]>
Signed-off-by: Simon L <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the attempt! I made some suggestions and commited them :)
Signed-off-by: Simon L <[email protected]> Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Simon L <[email protected]> Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Simon L <[email protected]>
Signed-off-by: Simon L <[email protected]>
@MarvvanPal what do you think about my changes? Do they look good? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thank you both for the approvals and @MarvvanPal for the PR! :) |
Close #3399
Close #3502
See commits for details.