Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimisations of the reverse proxy and docker rootless docs #3492

Conversation

MarvvanPal
Copy link
Contributor

@MarvvanPal MarvvanPal commented Oct 6, 2023

Close #3399
Close #3502
See commits for details.

Running a proxy manager directly on the host or in a container leads to different adaption of the example configurations. The description for this is simplified and more structured now. Additional the steps are written once and referenced per example configuration.

Signed-off-by: Marvin von Papen <[email protected]>
@szaimen szaimen added 3. to review Waiting for reviews documentation Improvements or additions to documentation labels Oct 6, 2023
@szaimen szaimen added this to the next milestone Oct 6, 2023
@szaimen szaimen changed the title 3399 optimisations of the installation description optimisations of the installation description Oct 6, 2023
@szaimen szaimen changed the title optimisations of the installation description optimisations of the reverse proxy docs Oct 6, 2023
@szaimen szaimen changed the title optimisations of the reverse proxy docs optimisations of the reverse proxy and docker rootless docs Oct 6, 2023
@szaimen szaimen modified the milestones: 7.4.1, next Oct 9, 2023
Signed-off-by: Simon L <[email protected]>
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the attempt! I made some suggestions and commited them :)

docker-rootless.md Outdated Show resolved Hide resolved
reverse-proxy.md Outdated Show resolved Hide resolved
Signed-off-by: Simon L <[email protected]>

Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Simon L <[email protected]>

Signed-off-by: Simon L. <[email protected]>
@szaimen
Copy link
Collaborator

szaimen commented Oct 10, 2023

@MarvvanPal what do you think about my changes? Do they look good? :)

@szaimen szaimen requested review from hunhejj and Zoey2936 October 10, 2023 10:06
Copy link
Collaborator

@hunhejj hunhejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@szaimen
Copy link
Collaborator

szaimen commented Oct 10, 2023

Thank you both for the approvals and @MarvvanPal for the PR! :)

@szaimen szaimen merged commit 92aae9d into nextcloud:main Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews documentation Improvements or additions to documentation
Projects
None yet
4 participants