Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mastercontainer - use Caddy for generating self-singed cert #3416

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Sep 26, 2023

Alternative approach to #3069
Supercedes #3069

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Sep 26, 2023
@szaimen szaimen added this to the next milestone Sep 26, 2023
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 26, 2023
@szaimen szaimen requested a review from Zoey2936 September 26, 2023 13:52
@szaimen
Copy link
Collaborator Author

szaimen commented Sep 27, 2023

@Zoey2936 would this approach be fine for you?

@Zoey2936
Copy link
Collaborator

@Zoey2936 would this approach be fine for you?

what is different to #3096?

@szaimen
Copy link
Collaborator Author

szaimen commented Sep 27, 2023

@Zoey2936 would this approach be fine for you?

what is different to #3096?

Mainly separating the change to caddy from moving to a full-blown apache conf which is better to test

@szaimen szaimen force-pushed the enh/noid/use-caddy-for-self-signed-cert branch from 9a0fd6d to 131dc62 Compare September 27, 2023 19:44
@szaimen szaimen requested review from Zoey2936 and removed request for Zoey2936 September 29, 2023 16:13
@szaimen
Copy link
Collaborator Author

szaimen commented Sep 29, 2023

Thanks :)

@szaimen szaimen merged commit b0c859a into main Sep 29, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/use-caddy-for-self-signed-cert branch September 29, 2023 16:16
@szaimen
Copy link
Collaborator Author

szaimen commented Oct 4, 2023

I fear this does not work. I get the following issue:

automation policy from site block is also default/catch-all policy because of key without hostname, and the two are in conflict: []certmagic.Issuer{(*caddytls.InternalIssuer)(0xc00032c360)} != []certmagic.Issuer{(*caddytls.ACMEIssuer)(0xc0003fce00)}

So reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants