-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mastercontainer - use Caddy for generating self-singed cert #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
szaimen
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Sep 26, 2023
szaimen
commented
Sep 26, 2023
@Zoey2936 would this approach be fine for you? |
Signed-off-by: Simon L <[email protected]>
Signed-off-by: Simon L <[email protected]>
szaimen
force-pushed
the
enh/noid/use-caddy-for-self-signed-cert
branch
from
September 27, 2023 19:44
9a0fd6d
to
131dc62
Compare
Zoey2936
approved these changes
Sep 29, 2023
Thanks :) |
delete-merged-branch
bot
deleted the
enh/noid/use-caddy-for-self-signed-cert
branch
September 29, 2023 16:16
I fear this does not work. I get the following issue:
So reverting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to #3069
Supercedes #3069