Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcListItem): Fix padding in RTL mode. #6359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

falghamdi125
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.52%. Comparing base (0d3715f) to head (e119ff5).
Report is 66 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6359      +/-   ##
==========================================
+ Coverage   42.26%   42.52%   +0.25%     
==========================================
  Files         155      156       +1     
  Lines        3996     4026      +30     
  Branches     1001     1012      +11     
==========================================
+ Hits         1689     1712      +23     
- Misses       2199     2201       +2     
- Partials      108      113       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This fixes the problem from the screen, but the component still has some problems on RTL, for example, with details.

Could you also fix other places where margin/padding sets different left/right values in this component, so it has complete RTL support?

@ShGKme ShGKme added bug Something isn't working feature: list-item Related to the list-item component RTL Right-to-Left languages support labels Jan 9, 2025
@ShGKme ShGKme added this to the 8.21.1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature: list-item Related to the list-item component RTL Right-to-Left languages support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] NcListItem padding in RTL mode
2 participants