Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step2-로또(자동) #1063

Open
wants to merge 6 commits into
base: janghomoon
Choose a base branch
from
Open

Conversation

janghomoon
Copy link

안녕하세요 작업 완료되어 PR 드립니다.

Copy link

@pci2676 pci2676 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조금 더 개선해보면 좋을 부분에 리뷰를 남겨두었으니 개선 후 다시 요청해주세요!

src/main/kotlin/autolotto/AutoLottoApplication.kt Outdated Show resolved Hide resolved
src/main/kotlin/autolotto/calculator/LottoCalculator.kt Outdated Show resolved Hide resolved

import kotlin.math.sign

object Valid {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

방어 로직만을 위한 util성 정적메서드만 모여있는 클래스 없이

객체 내부에서 검증을 하도록 모두 변경해보시면 좋을것 같습니다.

src/main/kotlin/autolotto/entity/Lotto.kt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants