[Step4] 수강신청(요구사항 변경) #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testrace
requested changes
Apr 21, 2024
Comment on lines
+51
to
+53
| public final void removeNotApproveUser() { | ||
| students.removeIf(student -> !approveStudents.contains(student)); | ||
| } |
There was a problem hiding this comment.
수강을 취소하더라도 신청 내역을 존재할 수 있을 것 같은데요
취소된 수강생을 삭제하기 보다 '수강생' 이라는 도메인을 도출해서 승인/선발 이라는 상태를 추가하면 어떨까요?
Comment on lines
15
to
+16
| private final Set<NsUser> students; | ||
| private final Set<NsUser> approveStudents; |
There was a problem hiding this comment.
선발 과정이후 students, approveStudents 두 필드의 요소는 같을 것으로 예상됩니다.
두 가지를 모두 가지고 있을 필요가 있을까요?
Comment on lines
+12
to
+16
| private final List<SessionImage> sessionImage; | ||
| private RecruitStatus recruitStatus; | ||
| private SessionProgressStatus sessionProgressStatus; | ||
| private final Set<NsUser> students; | ||
| private final Set<NsUser> approveStudents; |
There was a problem hiding this comment.
규칙 7: 3개 이상의 인스턴스 변수를 가진 클래스를 쓰지 않는다.
인스턴스 변수의 수를 줄이기 위해 도전한다.
'수강신청'과 관련된 필드만 모아서 객체를 도출하면 어떨까요?
| import java.util.stream.Collectors; | ||
|
|
||
| @Repository("sessionRepository") | ||
| public class JdbcPaySessionRepository implements PaySessionRepository { |
There was a problem hiding this comment.
Repository를 분리해주셨네요
두 SessionRepository의 컴포넌트 이름 "sessionRepository"은 일부러 같게 해주신걸까요?
그리고 '수강신청'과 관련된 흐름을 검증할 수 있게 Service 도 추가하면 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요.
이번엔 step3 리뷰 신청하고, step4를 바로 해봤었습니다.
그래서 중간에 conflict이 나서 commit 메시지가 지저분해졌습니다.
docs: 기능 목록 부터 보시면 될 것 같습니다!
벌써 마지막 과제네요. 잘 부탁드립니다.