๐ 2๋จ๊ณ - ๊นํ ๋ก๊ทธ์ธ ๊ตฌํ #613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
์ํ๋! ๋ก๊ทธ์ธ ํ ํ์์ ๋ณด๋ฅผ ์กฐํํ๋ ์ธ์ํ
์คํธ๊ฐ ๋ณด์ด์ง ์๋ค์. ๐ญ ์์ ํ ๋ค์ ๋ฆฌ๋ทฐ ์์ฒญ ๋ถํ๋๋ฆฝ๋๋ค! |
hiblue02
requested changes
Feb 26, 2024
Comment on lines
+3
to
+6
| public enum GithubResponse { | ||
| ์ฌ์ฉ์1("code1", "accessToken1","[email protected]"), | ||
| ์ฌ์ฉ์2("code2", "accessToken2","[email protected]"), | ||
| ์ฌ์ฉ์3("code3", "accessToken3","[email protected]"); |
There was a problem hiding this comment.
fake ๊ฐ์ฒด๊ฐ main์ ์๋ค์. ๐
| @@ -9,7 +10,7 @@ public class GlobalExceptionHandler { | |||
|
|
|||
| @ExceptionHandler(IllegalArgumentException.class) | |||
| public ResponseEntity<ErrorResponse> handleBadRequestException(IllegalArgumentException e) { | |||
| return ResponseEntity.badRequest().body(new ErrorResponse(e.getMessage())); | |||
| return ResponseEntity.status(HttpStatus.UNAUTHORIZED).body(new ErrorResponse(e.getMessage())); | |||
Comment on lines
+41
to
+42
| Station source = this.stationRepository.findById(request.getSource()).orElseThrow(() -> new RuntimeException("์กด์ฌํ์ง ์๋ ์ถ๋ฐ์ญ์ ๋๋ค.")); | ||
| Station target = this.stationRepository.findById(request.getTarget()).orElseThrow(() -> new RuntimeException("์กด์ฌํ์ง ์๋ ๋์ฐฉ์ญ์ ๋๋ค.")); |
There was a problem hiding this comment.
Exception์ ๋ฒ์๊ฐ ๋์ด์ก๋ค์. RuntimeException์ผ๋ก ๋ฐ๊พผ ์ด์ ๊ฐ ์์๊น์? ๐ค
Comment on lines
+13
to
+16
| @PostMapping("/github/access-token") | ||
| public ResponseEntity<GithubAccessTokenResponse> test(@RequestBody GithubAccessTokenRequest request) { | ||
| return ResponseEntity.ok(new GithubAccessTokenResponse(GithubResponse.findByCode(request.getCode()).getAccessToken())); | ||
| } |
There was a problem hiding this comment.
์ธ์ํ ์คํธ์์ fake(test/github/access-token)์ ํธ์ถํ๋ ๋ถ๋ถ์ด ๋ณด์ด์ง ์์์. ์ ๊ฐ ๋ชป์ฐพ์ ๊ฑธ๊น์? ๐ค
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.