Step0 #409
Open
Step0 #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkimm
commented
Aug 28, 2023
| // StationResponse의 필드가 추가되면 PathResponse의 Restdocs에도 반영 필요 -> 유지보수 어려움. | ||
| // then how? | ||
| return responseFields( | ||
| fieldWithPath("stations[].id").description("지하철 역 아이디"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
취준 중에 강의를 듣다 보니 면접과 병행하게 되어 뒤 늦게 PR을 올렸네요:( 고민 많이 해보며 설계하고 코드 작성해보겠습니다 잘부탁드립니다! 한솔님!:)
구현 사항
질문
PathResponseDto가List<StationResponse>를 필드로 가지고 있을 경우,StationResponse문서화에 대한 정보가StationDocumentation에도 있을 것이고,PathDocumentation에도 있는 문제가 생깁니다. 간단하게 생각하면PathResponse가 가지고 있는List<StationResponse>를List<PathStationResponse>로 변경하여 아예 새로운Response를 생성하는 방법이 있을 듯 합니다. 하지만 이 방법은 코드 재사용성이 떨어져 관리해야할 코드가 많아지는 단점이 있습니다. 한솔님은 어떻게 생각하시나요?