Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

refactor: Updated koa instrumentation to construct specs at instrumentation #171

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

bizob2828
Copy link
Member

Proposed Release Notes

  • Updated koa instrumentation to construct specs at instrumentation

Links

Closes #170

Details

This cannot be merged until the agent makes a release. The CI will fail because specs are not on the shim instance in a released version of agent yet.

To test locally

# npm link main of agent
npm link
# link in this PR
npm link newrelic
npm test

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.50%. Comparing base (cae5a63) to head (f60dc6e).

Files Patch % Lines
lib/router-instrumentation.js 96.82% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   94.18%   94.50%   +0.31%     
==========================================
  Files           6        6              
  Lines         361      382      +21     
==========================================
+ Hits          340      361      +21     
  Misses         21       21              
Flag Coverage Δ
unit-tests-16.x 40.57% <26.59%> (+0.68%) ⬆️
unit-tests-18.x 40.57% <26.59%> (+0.68%) ⬆️
unit-tests-20.x 40.57% <26.59%> (+0.68%) ⬆️
versioned-tests-16.x 94.50% <97.87%> (+0.31%) ⬆️
versioned-tests-18.x 94.50% <97.87%> (+0.31%) ⬆️
versioned-tests-20.x 94.50% <97.87%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr self-assigned this Feb 28, 2024
@bizob2828 bizob2828 merged commit 33bbc6e into main Feb 28, 2024
20 checks passed
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

koa: Update instrumentation to construct specs at instrumentation level
2 participants