Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

fix(request): Add x-request-id header to match spec #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jthurman42
Copy link
Contributor

Resolves #16

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jonathan Thurman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.


go 1.14

require github.com/google/uuid v1.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general our goal as been to not introduce new dependencies - for example, to create GUIDs in the Go Agent, we have our own method. Could something like that be used here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this could be refactored to do that, not sure I follow why though. Re-implementing a solution seems much more problematic / support burden / error prone than adding a dependency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning as I understand it is both so the library remains small, and doesn't take long for users to download and doesn't increase the size of their app, and also so that we don't need to worry about dependency versioning - if, for example, the user already is using this UUID library, but a different version in their app - there could be issues.

Happy to talk more about this when we chat tomorrow as well!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add x-request-id header to outbound requests.
3 participants