Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated getting-started-example for Go #473

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Updated getting-started-example for Go #473

merged 4 commits into from
Oct 19, 2023

Conversation

utr1903
Copy link
Contributor

@utr1903 utr1903 commented Oct 19, 2023

Changes

  • OTel SDK version is updated to the latest (at the moment v1.19.0).
  • OTel attribute value length limitation is added to docs.
  • Required manual instrumentation changes are updated in uninstrumented version.

jack-berg
jack-berg approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Is it safe to assume you tested this locally?

@utr1903
Copy link
Contributor Author

utr1903 commented Oct 19, 2023

Hey @jack-berg! Yeah, I've tested locally.

@jack-berg jack-berg merged commit d5c0058 into newrelic:main Oct 19, 2023
3 checks passed
@utr1903 utr1903 linked an issue Oct 20, 2023 that may be closed by this pull request
Update getting-started-example for Go #472
Closed
@utr1903 utr1903 mentioned this pull request Oct 20, 2023
Closed
@utr1903 utr1903 self-assigned this Oct 20, 2023
@utr1903 utr1903 added enhancement New feature or request language:go labels Oct 20, 2023
@utr1903 utr1903 deleted the utr1903/472 branch October 20, 2023 06:33
keegoid-nr pushed a commit to keegoid-nr/newrelic-opentelemetry-examples that referenced this pull request Nov 24, 2023
@utr1903
Updated getting-started-example for Go (newrelic#473)
f8a6a14 
* Add attribute length limit

* Update OTel SDK to 1.19.0

* Add comment

* Add attribute length limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

Assignees

@utr1903 utr1903

Labels
enhancement New feature or request language:go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update getting-started-example for Go
2 participants
@utr1903 @jack-berg