-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GCP Cloud Spanner example #468
Conversation
Co-authored-by: jack-berg <[email protected]>
@jack-berg / @alanwest ; Just checking in on this. I assume I shouldn't also be the one to approve an merge this since I raised the PR. Unfortunately because I had used my main branch to work on the confluent update it has a lot of commits, but most of them aren't related. I also have a fix for confluent because the variables I had removed were the wrong variables. That one is fairly straightforward. |
verbosity: normal | ||
processors: | ||
batch: | ||
memory_limiter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesnt look like you're using this below.
check_interval: 5s | ||
service: | ||
telemetry: | ||
logs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
metrics: | ||
receivers: [googlecloudspanner] | ||
processors: [batch] | ||
exporters: [otlp,logging] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment that the logging exporter is useful to see data flowing, but can be removed in production use cases?
@@ -0,0 +1,64 @@ | |||
# GCP Cloud Spanner OpenTelemetry metrics example setup | |||
|
|||
This example shows a setup for running a Docker OpenTelemetry Collector to scrape metrics from your GCP Cloud Spanner instance and post them the New Relic OTLP Collector Endpoint. You can view the metrics out of the box in New Relic by adding the [GCP Cloud Spanner dashboard](https://newrelic.com/instant-observability/google-cloud-spanner-otel) to your account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a TODO here to update the dashboard to reflect the shape of the data being sent up, and update the README to include details on how to install the dashboard when available.
Co-authored-by: jack-berg <[email protected]>
Creates an OTel receiver that pulls metrics from GCP Cloud Spanner and sends it to New Relic.