Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make log4j example easier to run against staging #455

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Make log4j example easier to run against staging #455

merged 1 commit into from
Oct 4, 2023

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Oct 4, 2023

@alanwest alanwest requested a review from a team October 4, 2023 18:10
alanwest
alanwest commented Oct 4, 2023
View reviewed changes
other-examples/java/logs-in-context-log4j2/README.md
@@ -36,15 +36,11 @@ The following image illustrates a similar example using FluentBit:
Next, build and run the application:

```shell
// Build the application
docker compose build
./gradlew logs-in-context-log4j2:bootJar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this actually necessary?

alanwest
alanwest commented Oct 4, 2023
View reviewed changes
other-examples/java/logs-in-context-log4j2/docker-compose.yaml
@@ -7,6 +7,7 @@ services:
# Logs are forwarded to collector using fluentd
OTEL_LOGS_EXPORTER: none
OTEL_EXPORTER_OTLP_ENDPOINT: 'http://collector:4317'
OTEL_EXPERIMENTAL_RESOURCE_DISABLED_KEYS: 'process.command_line,process.command_args'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is broken without this

@alanwest alanwest merged commit 08f648a into main Oct 4, 2023
2 checks passed
@alanwest alanwest deleted the alanwest/stuff branch October 4, 2023 18:15
jack-berg
jack-berg reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

keegoid-nr pushed a commit to keegoid-nr/newrelic-opentelemetry-examples that referenced this pull request Nov 24, 2023
@alanwest
Make log4j example easier to run (newrelic#455)
ee0f9bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanwest @jack-berg