Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify OpenTelemetry APM getting started documentation #17372

Merged
merged 15 commits into from
Jun 4, 2024

Conversation

alanwest
Copy link
Member

No description provided.

Copy link

Hi @alanwest 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented May 20, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 4ce89f4
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/665f80ee15f8010008b3db57
😎 Deploy Preview https://deploy-preview-17372--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ally-sassman ally-sassman added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels May 23, 2024
@alanwest alanwest marked this pull request as ready for review June 3, 2024 22:22
@ally-sassman ally-sassman self-assigned this Jun 4, 2024
@ally-sassman ally-sassman self-requested a review June 4, 2024 16:23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One thing worse discussing: We've removed any sort of general setup instructions, instead redirecting folks to language specific setup which are all are telling readers the same set of things. We have 6 sets of language specific examples while there are 11 otel language APIs / SDKs in some stage of development. If a user asks how to setup in a language we haven't provided an example for yet (seems inevitable) do you think we should just add a new example for that language rather than provide some generic set of instructions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jack-berg I think we could add a line saying, "If you're looking for more language-specific examples, submit a request (add link to do this, such as submitting a GitHub issue)"

cc @alanwest thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea @ally-sassman. Gives the user a concrete call to action, and provides us with a signal that someone is actively interested in an additional example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

jack-berg
jack-berg previously approved these changes Jun 4, 2024
<TechTile
name="Python"
icon="logo-python"
to="https://github.com/newrelic/newrelic-opentelemetry-examples/tree/main/getting-started-guides/python"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ally-sassman
ally-sassman previously approved these changes Jun 4, 2024
alanwest and others added 3 commits June 4, 2024 13:44
@ally-sassman ally-sassman merged commit fc76f06 into newrelic:develop Jun 4, 2024
17 checks passed
@jack-berg jack-berg mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants