Fix [resistance] without max_value bug

Fix wesnoth#8092 issue. If none [resistance] ability of the list contain max_avlue, on default value of 100 is used instead.
newfrenchy83 · Dec 8, 2023 · 5fd3157 · ProditorMagnus · Dec 8, 2023 · 5fd3157
1 parent a320377
commit 5fd3157
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/units/unit.cpp b/src/units/unit.cpp
@@ -1798,9 +1798,17 @@ int unit::resistance_against(const std::string& damage_name,bool attacker,const
 	if(!resistance_abilities.empty()) {
 		unit_abilities::effect resist_effect(resistance_abilities, 100-res);
 
+		bool has_max_value = false;
+		for(auto& i : resistance_abilities) {
+			if((*i.ability_cfg).has_attribute("max_value")){
+				has_max_value = true;
+				break;
+			}
+		}
+		int max_value = has_max_value ? resistance_abilities.highest("max_value").first : 100;
 		res = 100 - std::min<int>(
 			resist_effect.get_composite_value(),
-			resistance_abilities.highest("max_value").first
+			max_value
 		);
 	}