Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multicompartment reactions with source & destination in the ecs. #3296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support multicompartment reactions with source & destination in the ecs. #3296

wants to merge 2 commits into from

Conversation

adamjhn
Copy link
Member

@adamjhn adamjhn commented Dec 18, 2024

No description provided.

@adamjhn adamjhn added the rxd reaction-diffusion label Dec 18, 2024
@azure-pipelines Azure Pipelines
Copy link

✔️ 335e1e5 -> Azure artifacts URL

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (2e1379b) to head (8e9472e).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
share/lib/python/neuron/rxd/generalizedReaction.py 85.71% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3296      +/-   ##
==========================================
- Coverage   67.08%   67.07%   -0.01%     
==========================================
  Files         571      571              
  Lines      111093   111075      -18     
==========================================
- Hits        74527    74505      -22     
- Misses      36566    36570       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines Azure Pipelines
Copy link

✔️ 8e9472e -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #240398 (:no_entry:) have been uploaded here!

Status and direct links:

@adamjhn adamjhn requested a review from ramcdougal December 28, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramcdougal ramcdougal Awaiting requested review from ramcdougal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
rxd reaction-diffusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjhn @bbpbuildbot