Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative fix for hh.mod #3295

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Dec 18, 2024

Alternative to #3294, using the approach from #3294 (comment). Leaves both hh.mod files in a usable state.
Fixes #3000.

Copy link

✔️ 03203ca -> Azure artifacts URL

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (8dfe5a3) to head (92fc216).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3295   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         571      571           
  Lines      111055   111055           
=======================================
  Hits        74487    74487           
  Misses      36568    36568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmake/MacroHelper.cmake Outdated Show resolved Hide resolved
Copy link

✔️ 92fc216 -> Azure artifacts URL

@JCGoran JCGoran marked this pull request as ready for review December 19, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update hh.mod for CoreNEURON compatibility changes hh.mod in place during build
1 participant