Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cleanup script and Win32-specific function with std::filesystem #3292

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Dec 15, 2024

No description provided.

src/oc/hoc.cpp Outdated Show resolved Hide resolved
@JCGoran JCGoran marked this pull request as ready for review December 15, 2024 16:29
Copy link

✔️ 525bb61 -> Azure artifacts URL

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (bf6a457) to head (ffe2672).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3292   +/-   ##
=======================================
  Coverage   67.06%   67.07%           
=======================================
  Files         572      571    -1     
  Lines      111115   111055   -60     
=======================================
- Hits        74520    74487   -33     
+ Misses      36595    36568   -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/oc/hoc.cpp Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Cornu <[email protected]>
src/oc/hoc.cpp Outdated Show resolved Hide resolved
Copy link

✔️ 231a482 -> Azure artifacts URL

Co-authored-by: Nicolas Cornu <[email protected]>
Copy link

✔️ e00f56b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@alkino alkino enabled auto-merge (squash) December 16, 2024 09:33
Copy link

Copy link

✔️ ffe2672 -> Azure artifacts URL

@alkino alkino disabled auto-merge December 16, 2024 14:26
@alkino alkino enabled auto-merge (squash) December 16, 2024 14:26
@alkino alkino merged commit ad740c7 into master Dec 16, 2024
38 checks passed
@alkino alkino deleted the jelic/remove_cleanup branch December 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants