Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from deprecated PyWeakref_GetObject #3287

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

alkino
Copy link
Member

@alkino alkino commented Dec 12, 2024

PyWeakref_GetObject is deprecated from python 3.13 and will be remove for python 3.15

src/nrnpython/nrnpy_nrn.cpp Outdated Show resolved Hide resolved
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 4b1c23a -> Azure artifacts URL

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.06%. Comparing base (f2550af) to head (4b1c23a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_nrn.cpp 52.17% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3287   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files         572      572           
  Lines      111092   111115   +23     
=======================================
+ Hits        74499    74520   +21     
- Misses      36593    36595    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alkino alkino enabled auto-merge (squash) December 13, 2024 13:40
@alkino alkino merged commit bf6a457 into master Dec 13, 2024
38 checks passed
@alkino alkino deleted the cornu/pyweakref_getobject branch December 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants