HTList: keep minimal class #3281
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3281 +/- ##
==========================================
+ Coverage 67.06% 67.07% +0.01%
==========================================
Files 572 572
Lines 111115 111085 -30
==========================================
- Hits 74520 74514 -6
+ Misses 36595 36571 -24 ☔ View full report in Codecov by Sentry. |
|
✔️ 90ca008 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✔️ 1ed88ab -> Azure artifacts URL |
| @@ -66,21 +55,9 @@ inline bool HTList::IsEmpty() { | |||
| inline HTList* HTList::First() { | |||
| return _next; | |||
| } | |||
| inline HTList* HTList::Last() { | |||
There was a problem hiding this comment.
if there's a first there should be a last. it might not exist out of lazyness, but removing it feels excessive.
There was a problem hiding this comment.
the purpose of this patch was to reduce this class as most as possible, as no one will use it anymore (I hope). So when trying to replace by something else this become easier.
| inline HTList* HTList::End() { | ||
| return this; | ||
| } | ||
| inline HTList* HTList::Next() { | ||
| return _next; | ||
| } | ||
| inline HTList* HTList::Prev() { |
|
|
✔️ 38c488a -> Azure artifacts URL |
Pull request was closed
No description provided.