Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for install_name_tool issue #3278

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Dec 8, 2024

Hopefully fixes #3277.
According to the ld man page:

-headerpad_max_install_names
  Automatically adds space for future expansion of load commands such that all paths could expand
  to MAXPATHLEN.  Only useful if intend to run install_name_tool to alter the load commands later.

According to man 2 statfs:

     #define MAXPATHLEN      1024

which I'm guessing is the same MAXPATHLEN (haven't found references to any others), in which case we should be good for a while.

@JCGoran JCGoran requested a review from nrnhines December 8, 2024 16:11
Copy link

sonarqubecloud bot commented Dec 8, 2024

@alkino
Copy link
Member

alkino commented Dec 8, 2024

Nice find, useful to know

Copy link

✔️ 4976ad0 -> Azure artifacts URL

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.06%. Comparing base (d177f5b) to head (4976ad0).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3278      +/-   ##
==========================================
- Coverage   67.07%   67.06%   -0.01%     
==========================================
  Files         571      571              
  Lines      111110   111072      -38     
==========================================
- Hits        74528    74493      -35     
+ Misses      36582    36579       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCGoran JCGoran mentioned this pull request Dec 8, 2024
2 tasks
@JCGoran JCGoran merged commit 47b0359 into master Dec 9, 2024
36 checks passed
@JCGoran JCGoran deleted the jelic/fix_install_name_tool_issue branch December 9, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sporadic failures to build MacOS wheels due to install_name_tool errors
3 participants