Updated rxd reactions to allow pure backward reactions. #3273
Conversation
Also updated generalized reaction to try and avoid reactions where a species goes to a state becoming pure backward reactions because python gives priority to subclass operators.
| rate_b *= k | ||
| else: | ||
| rate_b *= k**v | ||
| rate_b *= k if v == 1 else k**v |
There was a problem hiding this comment.
Do we need this change? If this is just a cleanup, can we move this and any other cleanups into a second, later PR? The idea being to keep it clear what changes exist to address the backward reaction issue.
There was a problem hiding this comment.
I think we need this change. I removed some of the unnecessary formatting changes to generalizedReaction.py.
|
✔️ 8caef7f -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3273 +/- ##
==========================================
+ Coverage 67.06% 67.07% +0.01%
==========================================
Files 571 571
Lines 111070 111050 -20
==========================================
- Hits 74492 74490 -2
+ Misses 36578 36560 -18 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
|
✔️ e00e1cb -> Azure artifacts URL |
Also updated generalized reaction to try and avoid species to state reactions becoming pure backward reactions because python gives priority to subclass operators.