Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove Binomial and Poisson #3221

Closed
wants to merge 15 commits into from
Closed

WIP: Remove Binomial and Poisson #3221

wants to merge 15 commits into from

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 18, 2024

Binomial: the only CI diff is nrn-modeldb-ci20014 and this last one use no binomial.

@alkino alkino force-pushed the cornu/random/discrete branch 2 times, most recently from 706f0a6 to 78fba04 Compare November 18, 2024 11:24
@bbpbuildbot

This comment has been minimized.

@alkino alkino force-pushed the cornu/random/discrete branch from 78fba04 to 711fa3e Compare November 18, 2024 13:08
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 67.08%. Comparing base (29bf0a7) to head (c6f5268).

Files with missing lines Patch % Lines
src/gnu/distributions.hpp 25.00% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3221   +/-   ##
=======================================
  Coverage   67.07%   67.08%           
=======================================
  Files         569      567    -2     
  Lines      111170   111173    +3     
=======================================
+ Hits        74572    74578    +6     
+ Misses      36598    36595    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 711fa3e -> Azure artifacts URL

Copy link
Contributor

NEURON ModelDB CI: launching for 711fa3e via its drop url

@alkino alkino changed the title WIP: Remove Binomial WIP: Remove Binomial and DiscreteUniform Nov 19, 2024
Copy link

✔️ ccbf69b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@alkino alkino changed the title WIP: Remove Binomial and DiscreteUniform WIP: Remove Binomial and Poisson Nov 19, 2024
Copy link

✔️ c6f5268 -> Azure artifacts URL

@alkino alkino closed this Nov 19, 2024
@alkino alkino deleted the cornu/random/discrete branch December 10, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants