Only use nrn_prop_datum_alloc.

[1uc]

The aim of this refactoring is to make nrn_prop_datum_alloc the only function that allocates datums (for Prop; I'm not 100% sure about Datums in general).

I've attached a diagram of what I think is currently how prop.dparam is allocated and freed. There's still one alternative path remaining, via the global variable nrn_point_prop_. However, I suspect this will naturally go away when we store the datums inside the SoA.

[1uc]

I'm unable to find the associated free through grepping.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[azure-pipelines]

✔️ e701266 -> Azure artifacts URL

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (45cdea7) 66.18% compared to head (e701266) 66.32%.
Report is 7 commits behind head on master.

Files	Patch %	Lines
src/nrniv/hocmech.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2683      +/-   ##
==========================================
+ Coverage   66.18%   66.32%   +0.13%     
==========================================
  Files         559      559              
  Lines      108940   108657     -283     
==========================================
- Hits        72107    72064      -43     
+ Misses      36833    36593     -240     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bbpbuildbot]

Logfiles from GitLab pipeline #187515 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[github-actions]

NEURON ModelDB CI: launching for e701266 via its drop url

[github-actions]

NEURON ModelDB CI: e701266 -> download reports from here

[nrnhines]

Looks good to me.