Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move memory related functions to memory.[ch]pp #2677

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Move memory related functions to memory.[ch]pp #2677

merged 6 commits into from
Jan 19, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Jan 18, 2024

It was in symbols.cpp

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link

✔️ f42bb82 -> Azure artifacts URL

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (fbacf4f) 66.32% compared to head (f42bb82) 66.33%.

Files Patch % Lines
src/oc/memory.cpp 81.25% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2677   +/-   ##
=======================================
  Coverage   66.32%   66.33%           
=======================================
  Files         558      559    +1     
  Lines      108662   108655    -7     
=======================================
- Hits        72073    72072    -1     
+ Misses      36589    36583    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit c164100 into master Jan 19, 2024
36 of 37 checks passed
@pramodk pramodk deleted the cornu/memory branch January 19, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants