Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make memb_func a vector #2566

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Make memb_func a vector #2566

merged 6 commits into from
Oct 5, 2023

Conversation

ohm314
Copy link
Member

@ohm314 ohm314 commented Oct 2, 2023

No description provided.

@azure-pipelines
Copy link

✔️ af05871 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@azure-pipelines
Copy link

✔️ 7265933 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #2566 (7265933) into master (5868cdd) will decrease coverage by 0.01%.
The diff coverage is 98.14%.

@@            Coverage Diff             @@
##           master    #2566      +/-   ##
==========================================
- Coverage   61.49%   61.49%   -0.01%     
==========================================
  Files         623      623              
  Lines      119197   119196       -1     
==========================================
- Hits        73296    73294       -2     
- Misses      45901    45902       +1
Files Coverage Δ
src/nmodl/nocpout.cpp 95.08% <ø> (ø)
src/nrncvode/cvtrset.cpp 97.67% <100.00%> (ø)
src/nrncvode/netcvode.cpp 88.33% <100.00%> (-0.01%) ⬇️
src/nrniv/nrncore_write.cpp 84.21% <100.00%> (ø)
src/nrnoc/init.cpp 89.82% <100.00%> (ø)
src/nrnoc/membfunc.h 100.00% <ø> (ø)
src/nrnpython/nrnpy_nrn.cpp 72.80% <100.00%> (ø)
src/nrncvode/occvode.cpp 95.10% <95.65%> (+<0.01%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #157997 (:white_check_mark:) have been uploaded here!

Status and direct links:

@ohm314 ohm314 requested review from iomaganaris, alkino and 1uc October 5, 2023 07:28
@pramodk pramodk merged commit 66a7c0e into master Oct 5, 2023
37 of 38 checks passed
@pramodk pramodk deleted the ohm314/vector_memb_func branch October 5, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk approved these changes

@iomaganaris iomaganaris Awaiting requested review from iomaganaris

@alkino alkino Awaiting requested review from alkino

@1uc 1uc Awaiting requested review from 1uc

Assignees
No one assigned
Labels
hackron2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohm314 @bbpbuildbot @pramodk