Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework _STRIDE. #2559

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Rework _STRIDE. #2559

merged 1 commit into from
Oct 4, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Sep 28, 2023

No description provided.

@1uc 1uc changed the title Rework highly misleading macro. Rework _STRIDE. Sep 28, 2023
@1uc 1uc force-pushed the 1uc/rework-_STRIDE branch from 21fd9d8 to 054b32b Compare September 28, 2023 13:25
@azure-pipelines
Copy link

✔️ 054b32b -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2559 (054b32b) into master (53c9392) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2559      +/-   ##
==========================================
- Coverage   61.48%   61.48%   -0.01%     
==========================================
  Files         623      623              
  Lines      119164   119163       -1     
==========================================
- Hits        73265    73263       -2     
- Misses      45899    45900       +1     
Files Coverage Δ
src/coreneuron/mechanism/capac.cpp 61.81% <ø> (ø)
src/coreneuron/mechanism/eion.cpp 78.50% <ø> (ø)
src/coreneuron/sim/scopmath/crout_thread.hpp 89.28% <ø> (ø)
src/coreneuron/sim/scopmath/newton_thread.hpp 85.48% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still draft but LGTM

@1uc
Copy link
Collaborator Author

1uc commented Sep 29, 2023

Check ModelDB CI?

@1uc 1uc marked this pull request as ready for review September 29, 2023 12:08
@github-actions
Copy link
Contributor

NEURON ModelDB CI: launching for 054b32b via its drop url

@pramodk
Copy link
Member

pramodk commented Oct 4, 2023

ModelDB CI was failed for unrelated reasons. The change is straightforward and hence merging this.

@pramodk pramodk enabled auto-merge (squash) October 4, 2023 14:56
@pramodk pramodk disabled auto-merge October 4, 2023 14:56
@pramodk pramodk merged commit 88d6f09 into master Oct 4, 2023
35 of 36 checks passed
@pramodk pramodk deleted the 1uc/rework-_STRIDE branch October 4, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants