Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Nanobind. Fix object leak in from_numpy #2545

Merged
merged 100 commits into from
Jun 26, 2024

Try

db63912
Select commit
Loading
Failed to load commit list.
Merged

Bring Nanobind. Fix object leak in from_numpy #2545

Try
db63912
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 31, 2024 in 1s

67.19% (-0.01%) compared to 71bf299, passed because coverage increased by +0.00% when compared to adjusted base (67.19%)

View this Pull Request on Codecov

67.19% (-0.01%) compared to 71bf299, passed because coverage increased by +0.00% when compared to adjusted base (67.19%)

Details

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.19%. Comparing base (71bf299) to head (db63912).

Current head db63912 differs from pull request most recent head 4147249

Please upload reports for the commit 4147249 to get more accurate results.

Files Patch % Lines
src/nrnpython/nrnpy_hoc.cpp 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2545      +/-   ##
==========================================
- Coverage   67.20%   67.19%   -0.01%     
==========================================
  Files         563      563              
  Lines      104254   104250       -4     
==========================================
- Hits        70059    70053       -6     
- Misses      34195    34197       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.