Fix leak in nrn_thread_free.
#2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspect that the allocation happens here: Lines 503 to 508 in 88d7962 |
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #2541 +/- ##
==========================================
- Coverage 61.49% 61.48% -0.02%
==========================================
Files 623 623
Lines 119163 119163
==========================================
- Hits 73281 73265 -16
- Misses 45882 45898 +16
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
✔️ e2de83f -> Azure artifacts URL |
|
@1uc : rebasing this on the master to get the CI part going. |
This comment has been minimized.
This comment has been minimized.
The array of `Prop*` is allocated unconditionally in `thread_memblist_setup`.
tml->ml->prop = new Prop*[mlcnt[i]]; // used for ode_map
if (!memb_func[i].hoc_mech) {
CACHELINE_ALLOC(tml->ml->pdata, Datum*, mlcnt[i]);
}
Hence this commit adjust the logic in `nrn_thread_free` deallocate `ml->prop`
unconditionally.
1uc
force-pushed
the
1uc/fix-nrn_thread_free
branch
from
36f59bc to
e057dee
Compare
|
✔️ 36f59bc -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/fix-nrn_thread_free
branch
from
e057dee to
9cc76c1
Compare
|
✔️ 9cc76c1 -> Azure artifacts URL |
nrnhines
reviewed
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array of
Prop*is allocated unconditionally inthread_memblist_setup.Hence this commit adjust the logic in
nrn_thread_freedeallocateml->propunconditionally.