Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers MSVC complains about #2537

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Fix headers MSVC complains about #2537

merged 3 commits into from
Sep 27, 2023

Conversation

matz-e
Copy link
Collaborator

@matz-e matz-e commented Sep 26, 2023

No description provided.

@matz-e matz-e requested review from ohm314 and pramodk September 26, 2023 13:25
@azure-pipelines
Copy link

✔️ baec603 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2537 (baec603) into master (b4fdb4c) will decrease coverage by 0.01%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

❗ Current head baec603 differs from pull request most recent head cc5adb3. Consider uploading reports for the commit cc5adb3 to get more accurate results

@@            Coverage Diff             @@
##           master    #2537      +/-   ##
==========================================
- Coverage   61.48%   61.48%   -0.01%     
==========================================
  Files         623      623              
  Lines      119146   119153       +7     
==========================================
- Hits        73261    73260       -1     
- Misses      45885    45893       +8     
Files Coverage Δ
src/nmodl/nocpout.cpp 95.08% <ø> (ø)
src/oc/wrap_sprintf.h 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohm314 ohm314 merged commit 90eca81 into master Sep 27, 2023
4 of 13 checks passed
@matz-e matz-e deleted the fix-headers branch September 28, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants