No more CopyString when Interviews is not used #2483
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✔️ 5f0eaae -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
alkino
force-pushed
the
cornu/no_more_ivos_string
branch
from
5f0eaae to
96049c9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
✔️ 7a17083 -> Azure artifacts URL |
Codecov Report
@@ Coverage Diff @@
## master #2483 +/- ##
==========================================
- Coverage 61.49% 61.49% -0.01%
==========================================
Files 624 624
Lines 119026 118980 -46
==========================================
- Hits 73197 73162 -35
+ Misses 45829 45818 -11
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alkino
changed the title
There was a problem hiding this comment.
LGTM.
The change seems straightforward. But with all the string manipulation/code generation in string form, possibility to miss something, and hence it would have been nice to have some existing tests for this. @nrnhines : something to consider?
Anyway, I will merge this. Adding tests could be a separate, standalone task.
| o << buf << std::endl; | ||
| Sprintf(buf, "save_window_.save_name(\"%s\")", var_name_->string()); | ||
| o << buf << std::endl; | ||
| o << "save_window_.save_name(\"" << var_name_ << "\")" << std::endl; |
There was a problem hiding this comment.
just a comment: these are straightforward but having test somewhere about this would have been nice!
| char* s = (char*)(string()); | ||
| delete [] s; | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
Just a question: haven't read the usage of this but do you know/understand "why" was this implemented in first place if the code was C++ ? 🤔
There was a problem hiding this comment.
IIRC it has been moved to C++ later. Interviews was added to fulfill what was not yet in the C/C++-standard: strings and basic things like that.
No description provided.