Test the new module

CMakeLists.txt

@@ -433,7 +433,7 @@ if(NRN_ENABLE_PYTHON)
   # Make sure the USE_PYTHON macro is defined in the C++ code
   list(APPEND NRN_COMPILE_DEFS USE_PYTHON)
   # Ensure nanobind is there, but dont import, we don't want its CMake
-  nrn_add_external_project(nanobind False)
+  nrn_add_external_project(nanobind DISABLE_ADD RECURSIVE SHALLOW)
   include(NanoBindMinimal)
 endif()
 

cmake/ExternalProjectHelper.cmake

@@ -23,13 +23,21 @@ endfunction(nrn_submodule_file_not_found)
 
 # initialize submodule with given path
 function(nrn_initialize_submodule path)
+  cmake_parse_arguments(PARSE_ARGV 1 opt "RECURSIVE;SHALLOW" "" "")
+  set(UPDATE_OPTIONS "")
+  if(opt_RECURSIVE)
+    list(APPEND UPDATE_OPTIONS --recursive)
+  endif()
+  if(opt_SHALLOW)
+    list(APPEND UPDATE_OPTIONS --depth 1)
+  endif()
   if(NOT ${GIT_FOUND})
     message(
       FATAL_ERROR "git not found and ${path} sub-module not cloned (use git clone --recursive)")
   endif()
-  message(STATUS "Sub-module : missing ${path} : running git submodule update --init")
+  message(FATAL_ERROR "Sub-module : missing ${path} : running git submodule update ${UPDATE_OPTIONS} --init")
   execute_process(
-    COMMAND ${GIT_EXECUTABLE} submodule update --recursive --init -- ${path}
+    COMMAND ${GIT_EXECUTABLE} submodule update ${UPDATE_OPTIONS} --init -- ${path}
     WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
     RESULT_VARIABLE ret)
   if(NOT ret EQUAL 0)
@@ -39,20 +47,28 @@ endfunction()
 
 # check for external project and initialize submodule if it is missing
 function(nrn_add_external_project name)
+  cmake_parse_arguments(PARSE_ARGV 1 opt "RECURSIVE;SHALLOW;DISABLE_ADD" "" "")
   find_path(
     ${name}_PATH
     NAMES CMakeLists.txt
     PATHS "${THIRD_PARTY_DIRECTORY}/${name}"
     NO_DEFAULT_PATH)
   if(NOT EXISTS ${${name}_PATH})
     nrn_submodule_file_not_found("${THIRD_PARTY_DIRECTORY}/${name}")
-    nrn_initialize_submodule("${THIRD_PARTY_DIRECTORY}/${name}")
+    set(OPTIONS "")
+    if(opt_RECURSIVE)
+      list(APPEND OPTIONS "RECURSIVE")
+    endif()
+    if (opt_SHALLOW)
+      list (APPEND OPTIONS "SHALLOW")
+    endif()
+    nrn_initialize_submodule("${THIRD_PARTY_DIRECTORY}/${name}" ${OPTIONS})
   else()
     message(STATUS "Sub-project : using ${name} from from ${THIRD_PARTY_DIRECTORY}/${name}")
   endif()
   # if second argument is passed and if it's OFF then skip add_subdirectory
   if(${ARGC} GREATER 1)
-    if(${ARGV2})
+    if(NOT opt_DISABLE_ADD)
       add_subdirectory("${THIRD_PARTY_DIRECTORY}/${name}")
     endif()
   else()

src/coreneuron/CMakeLists.txt

@@ -267,7 +267,7 @@ else()
   set(NMODL_ENABLE_PYTHON_BINDINGS
       OFF
       CACHE BOOL "Enable NMODL python bindings")
-  nrn_add_external_project(nmodl OFF)
+  nrn_add_external_project(nmodl DISABLE_ADD)
   add_subdirectory(${PROJECT_SOURCE_DIR}/external/nmodl ${CMAKE_BINARY_DIR}/external/nmodl)
   set(CORENRN_NMODL_BINARY ${CMAKE_BINARY_DIR}/bin/nmodl${CMAKE_EXECUTABLE_SUFFIX})
   set(CORENRN_NMODL_INCLUDE ${CMAKE_BINARY_DIR}/include)