-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logger_name
option
#30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks @JoeZiminski. I've left one comment. Would you also mind adding it's use to example.py
too? That's the closest thing we have to docs currently!
Hey @adamltyson sure, I have added it in the example, making it the 'canonical' way to use |
BTW after this PR could we release as a new version so it will be downloaded from PyPI? Will help with some |
I think this is fine, I've created #31 to track documenting fancylog properly. Will release now. |
New version is released ( |
Cheers! |
What is this PR
Why is this PR needed? & What does this PR do?
This PR adds a
logger_name
variable that lets the logger than fancylog sets up be given a name. This is usefulfor grabbing this logger at a later time.
How has this PR been tested?
Added new test to check expected
logger_name
is created.Change is not breaking nor requires documentation change.
Checklist: