will add auto exposure time upper and lower limits, so we can acheive… #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… faster fps in auto exposure mode by limiting upper limit, removed old master_fps params
ghost
suggested changes
Sep 24, 2019
There was a problem hiding this comment.
Mithun,
We should define a no set value as -1 or 0. This should mean that this parameter is not being set, thus in the code we don't set any values when the variable is 'set to the no set value'. The benefit of doing it like that is that if certain models of cameras have a different range of values we can set, this will not affect it. What do you think?
|
Mithun can you implement these changes and merge. I think it will be useful for Jagat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will add auto exposure time upper and lower limits, so we can acheive faster fps in auto exposure mode by limiting upper limit, removed old master_fps param