struct insn: remove unused forw_ref flag

The forw_ref flag in struct insn was being set but never actually read anywhere. Signed-off-by: H. Peter Anvin <[email protected]>
netwide-assembler · Aug 10, 2024 · 7c47273 · 7c47273
1 parent 86142b0
commit 7c47273
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/asm/nasm.c b/asm/nasm.c
@@ -1564,18 +1564,15 @@ static void forward_refs(insn *instruction)
     int i;
     struct forwrefinfo *fwinf;
 
-    instruction->forw_ref = false;
-
     if (!optimizing.level)
-        return;                 /* For -O0 don't bother */
+        return;                 /* For -O1 don't bother */
 
     if (!forwref)
         return;
 
     if (forwref->lineno != globallineno)
         return;
 
-    instruction->forw_ref = true;
     do {
         instruction->oprs[forwref->operand].opflags |= OPFLAG_FORWARD;
         forwref = saa_rstruct(forwrefs);

diff --git a/asm/parser.c b/asm/parser.c
@@ -637,7 +637,6 @@ insn *parse_line(char *buffer, insn *result)
 
 restart_parse:
     first               = true;
-    result->forw_ref    = false;
 
     stdscan_reset();
     stdscan_set(buffer);
@@ -988,9 +987,6 @@ insn *parse_line(char *buffer, insn *result)
         value = evaluate(stdscan, NULL, &tokval,
                          &op->opflags, critical, &hints);
         i = tokval.t_type;
-        if (op->opflags & OPFLAG_FORWARD) {
-            result->forw_ref = true;
-        }
         if (!value)                  /* Error in evaluator */
             goto fail;
 

diff --git a/include/nasm.h b/include/nasm.h
@@ -759,7 +759,6 @@ typedef struct insn { /* an instruction itself */
     extop           *eops;                  /* extended operands */
     int             eops_float;             /* true if DD and floating */
     int32_t         times;                  /* repeat count (TIMES prefix) */
-    bool            forw_ref;               /* is there a forward reference? */
     bool            rex_done;               /* REX prefix emitted? */
     int             rex;                    /* Special REX Prefix */
     int             vexreg;                 /* Register encoded in VEX prefix */