Skip to content

Commit

Permalink
build: Fail build on compilation error (#1473)
Browse files Browse the repository at this point in the history
* build: Fail build on compilation error

* build: Fail build on compilation error
  • Loading branch information
ddeboer authored Dec 3, 2024
1 parent 95f778c commit 8679029
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ jobs:
- run: npm ci
- run: npm run check
- run: npm test
- run: npm run compile
- run: npm run compile --workspaces
- run: npx commitlint --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
with:
node-version: lts/*
- run: npm ci
- run: npm run compile
- run: npm run compile --workspaces
- run: npm run release
env:
# Use a personal access token (PAT) so we can trigger downstream workflows (deploy.yml).
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
"typescript": "^5.5.4"
},
"scripts": {
"clean": "npm run clean --workspaces",
"compile": "npm run compile --workspaces",
"check": "gts check",
"fix": "gts fix",
"commitlint": "commitlint --edit $1",
Expand Down

0 comments on commit 8679029

Please sign in to comment.