fix: Rename description to definition (#1447)

`skos:description` does not exist, so rename to `skos:definition`.
netwerk-digitaal-erfgoed · Oct 28, 2024 · 70d6857 · 70d6857
1 parent 40f9033
commit 70d6857
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/packages/network-of-terms-graphql/README.md b/packages/network-of-terms-graphql/README.md
@@ -111,6 +111,7 @@ query {
           prefLabel
           altLabel
           hiddenLabel
+          definition 
           scopeNote
           seeAlso
           broader {
@@ -166,6 +167,7 @@ query {
           prefLabel
           altLabel
           hiddenLabel
+          definition 
           scopeNote
           seeAlso
         }
@@ -210,6 +212,7 @@ query {
         prefLabel
         altLabel
         hiddenLabel
+        definition 
         scopeNote
         seeAlso
         broader {

diff --git a/packages/network-of-terms-graphql/src/resolvers.ts b/packages/network-of-terms-graphql/src/resolvers.ts
@@ -115,7 +115,7 @@ function term(term: Term) {
     hiddenLabel: term.hiddenLabels.map(
       (hiddenLabel: RDF.Term) => hiddenLabel.value
     ),
-    description: term.scopeNotes.map((scopeNote: RDF.Term) => scopeNote.value),
+    definition: term.scopeNotes.map((scopeNote: RDF.Term) => scopeNote.value),
     scopeNote: term.scopeNotes.map((scopeNote: RDF.Term) => scopeNote.value),
     seeAlso: term.seeAlso.map((seeAlso: RDF.NamedNode) => seeAlso.value),
     broader: term.broaderTerms.map(related => ({

diff --git a/packages/network-of-terms-graphql/src/schema.ts b/packages/network-of-terms-graphql/src/schema.ts
@@ -52,8 +52,8 @@ export const schema = `
     prefLabel: [String]!
     altLabel: [String]!
     hiddenLabel: [String]!
-    description: [String]!
-    "For the full description of the term, use \`description\` instead of scopeNote. The contents of \`scopeNote\` may change later."
+    definition: [String]!
+    "For the full definition of the term, use \`definition\` instead of \`scopeNote\`. The contents of \`scopeNote\` may change later."
     scopeNote: [String]!
     seeAlso: [String]!
     broader: [RelatedTerm]

diff --git a/packages/network-of-terms-graphql/test/server.test.ts b/packages/network-of-terms-graphql/test/server.test.ts
@@ -108,7 +108,7 @@ describe('Server', () => {
         term.uri === 'https://example.com/resources/artwork'
     );
     expect(artwork.seeAlso).toEqual(['https://example.com/html/artwork']);
-    expect(artwork.description).toEqual([
+    expect(artwork.definition).toEqual([
       'One of the most famous Dutch paintings',
     ]);
     expect(artwork.exactMatch).toEqual([
@@ -259,7 +259,7 @@ function termsQuery(sources: string[], query = 'nachtwacht') {
               prefLabel
               altLabel
               hiddenLabel
-              description
+              definition
               scopeNote
               seeAlso
               broader {