Validators::isInRange() ignores NULL

nette · Mar 29, 2017 · b3be7ea · b3be7ea
1 parent 1319046
commit b3be7ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Utils/Validators.php b/src/Utils/Validators.php
@@ -238,7 +238,8 @@ public static function isList($value): bool
 	 */
 	public static function isInRange($value, array $range): bool
 	{
-		return (!isset($range[0]) || $range[0] === '' || $value >= $range[0])
+		return $value !== NULL
+			&& (!isset($range[0]) || $range[0] === '' || $value >= $range[0])
 			&& (!isset($range[1]) || $range[1] === '' || $value <= $range[1]);
 	}
 

diff --git a/tests/Utils/Validators.isInRange().phpt b/tests/Utils/Validators.isInRange().phpt
@@ -29,3 +29,6 @@ Assert::true(Validators::isInRange(-1, ['', 2]));
 
 Assert::true(Validators::isInRange(1, [-1, NULL]));
 Assert::true(Validators::isInRange(1, [-1, '']));
+
+Assert::false(Validators::isInRange(NULL, [0, 1]));
+Assert::false(Validators::isInRange(NULL, ['0', 'b']));