Automatic conversion enum/int - when mapping to class #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- global is for testing & building - nette-forms moved to src/assets
…tValue() instead of loadHttpData()
…dClass (BC break)
Nette forms doesnt support data type Enum when mapping form values to class. This makes problems when using forms - see error reported here: https://forum.nette.org/cs/36594-prevod-vybraneho-optionu-v-selectu-na-enum-type The fix isnt complicated and makes no BC break. The case is in more details discussed here: https://forum.nette.org/cs/36601-rfc-konverze-na-datovy-typ-enum-a-int-pri-mapovani-hodnot-formulare
dg
added a commit
that referenced
this pull request
Aug 5, 2024
dg
added a commit
that referenced
this pull request
Aug 5, 2024
dg
added a commit
that referenced
this pull request
Aug 5, 2024
dg
added a commit
that referenced
this pull request
Aug 5, 2024
dg
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nette forms doesnt support data type Enum when mapping form values to class. This makes problems when using forms with mapping values to class - see error reported here: https://forum.nette.org/cs/36594-prevod-vybraneho-optionu-v-selectu-na-enum-type
In some cases might be useful also automatic conversion of string value to int - if data type int is defined in some property in data class and form control supplies string.
The proposed change of the code isnt complicated and makes no BC break. The case is in details described here: https://forum.nette.org/cs/36601-rfc-konverze-na-datovy-typ-enum-a-int-pri-mapovani-hodnot-formulare