Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug missing setting setOmitted(true) in Button.php #330

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mildabre
Copy link
Contributor

@mildabre mildabre commented May 4, 2024

If form is submitted with standard SubmitButton and in the form is another button Button, the attribute name + value appears in $values of the form. This is undesirable behaviour and my proposal fixes this bug.

Notice: in the class Nette\Forms\Controls\SubmitButton in constructor is similar call setOmitted(true) which would be redundant after accepting this PR and could be removed for simplicity. I will send another PR.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
If form is submitted with standard SubmitButton and in the form is another button Button, the attribute name + value appears in $values of the form. This is undesirable behaviour and my proposal fixes this bug.
@dg dg force-pushed the master branch 6 times, most recently from 94f43f0 to fe374c5 Compare May 12, 2024 13:07
@dg dg force-pushed the master branch 2 times, most recently from 5b93c75 to 2146e59 Compare August 5, 2024 22:16
@dg dg merged commit 7abcc8c into nette:master Aug 5, 2024
10 of 11 checks passed
dg pushed a commit that referenced this pull request Aug 5, 2024
dg pushed a commit that referenced this pull request Aug 5, 2024
dg pushed a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants