Fixes bug with orderByDistanceFrom methods for Postgres and SQLServer

netsells · Mar 2, 2020 · 9d51963 · 9d51963
1 parent d6b0dcb
commit 9d51963
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,3 +20,4 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 * [1.4.0](#400---2020-01-14) - Adds support for DB builder
 * [1.4.1](#400---2020-02-10) - Fixes config publish command
 * [1.5.0](#400---2020-02-29) - Adds orderByDistanceFrom methods
+* [1.5.1](#400---2020-02-29) - Fixes bug with orderByDistanceFrom methods for Postgres and SQLServer
diff --git a/src/ScopeDrivers/PostgreSQLScopeDriver.php b/src/ScopeDrivers/PostgreSQLScopeDriver.php
@@ -43,8 +43,8 @@ public function orderByDistanceFrom(float $lat, float $long, string $orderDirect
         $this->checkOrderDirectionIdentifier($orderDirection);
 
         return $this->query->orderByRaw($this->getOrderByDistanceSQL($orderDirection), [
-            $long,
             $lat,
+            $long,
         ]);
     }
 

diff --git a/src/ScopeDrivers/SQLServerScopeDriver.php b/src/ScopeDrivers/SQLServerScopeDriver.php
@@ -43,8 +43,8 @@ public function orderByDistanceFrom(float $lat, float $long, string $orderDirect
         $this->checkOrderDirectionIdentifier($orderDirection);
 
         return $this->query->orderByRaw($this->getOrderByDistanceSQL($orderDirection), [
-            $long,
             $lat,
+            $long,
         ]);
     }
-Original file line number
+Diff line change
@@ Expand Up @@
             $this->checkOrderDirectionIdentifier($orderDirection);
             return $this->query->orderByRaw($this->getOrderByDistanceSQL($orderDirection), [
-                $long,
                 $lat,
+                $long,
             ]);
         }
@@ Expand Down @@