Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct file extensions for transpilation #6256

Merged

Conversation

estephinson
Copy link
Contributor

@estephinson estephinson commented Dec 7, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

When we did the mass .m(ts|js) -> .(js|ts) extension change these got caught up. This effected the function transpillation process as it was parsing the wrong file types, creating a nested functions-serve directory which borked the gatsby plugin


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@estephinson estephinson requested a review from a team as a code owner December 7, 2023 15:12
sarahetter
sarahetter previously approved these changes Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

📊 Benchmark results

Comparing with 7e3349c

  • Dependency count: 1,399 (no change)
  • Package size: 405 MB ⬇️ 0.00% decrease vs. 7e3349c
  • Number of ts-expect-error directives: 1,331 (no change)

@estephinson estephinson added the automerge Add to Kodiak auto merge queue label Dec 7, 2023
@kodiakhq kodiakhq bot merged commit 8308097 into main Dec 8, 2023
35 checks passed
@kodiakhq kodiakhq bot deleted the ed/ct-363-frameworks-flakiness-with-netlify-cli-after-1770 branch December 8, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants