Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace got with node-fetch on edge-functions.test.ts #6248

Merged

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Dec 5, 2023

Summary

refactor: replace got with node-fetch on edge-functions.test.ts

related to #5695


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@hereje hereje requested a review from a team as a code owner December 5, 2023 21:35
Copy link

github-actions bot commented Dec 5, 2023

📊 Benchmark results

Comparing with 8834fbc

  • Dependency count: 1,399 (no change)
  • Package size: 405 MB ⬆️ 0.00% increase vs. 8834fbc
  • Number of ts-expect-error directives: 1,292 (no change)

sarahetter
sarahetter previously approved these changes Dec 7, 2023
@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Dec 13, 2023
@sarahetter sarahetter added automerge Add to Kodiak auto merge queue and removed automerge Add to Kodiak auto merge queue labels Dec 14, 2023
@sarahetter sarahetter merged commit a5740db into netlify:main Dec 14, 2023
34 checks passed
@hereje hereje deleted the refactor/replace-got/edge-functions.test.ts branch December 14, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants