Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace got with node-fetch on functions-invoke.test.ts #6232

Merged

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Nov 30, 2023

Summary

replace got with node-fetch

related to #5695


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@hereje hereje requested a review from a team as a code owner November 30, 2023 17:05
Copy link

github-actions bot commented Nov 30, 2023

πŸ“Š Benchmark results

Comparing with e3f654e

  • Dependency count: 1,399 (no change)
  • Package size: 405 MB (no change)
  • Number of ts-expect-error directives: 1,292 (no change)

@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Dec 13, 2023
@kodiakhq kodiakhq bot merged commit 8e71e42 into netlify:main Dec 13, 2023
34 checks passed
@hereje hereje deleted the refactor/replace-got/functions-invoke.test.ts branch December 13, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants