Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSH key deletion error bug #914

Merged

Conversation

Mattia013
Copy link
Contributor

@Mattia013 Mattia013 commented Nov 15, 2024

Description

Fix delete modal to prompt for the specific SSH key record in table.

When multiple SSH keys are available and we try to remove one, it is always prompted to remove the last one.
This should fix this undesired behavior.

How Has This Been Tested?

The test was done recreating the SSHKeysTable in a new React Typescript project.

@Mattia013 Mattia013 requested a review from a team as a code owner November 15, 2024 21:57
@kingmakerbot
Copy link
Collaborator

Hi @Mattia013. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@Mattia013 Mattia013 changed the title Fix SSH key error bug Fix SSH key deletion error bug Nov 15, 2024
@frisso
Copy link
Member

frisso commented Nov 16, 2024

Thanks @Mattia013 for this contribution!
@QcFe This looks very good to me.
If you agree, we can approve and merge.
Thanks to you both!

@QcFe
Copy link
Collaborator

QcFe commented Nov 16, 2024

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-914 label to your tenant.

Copy link
Collaborator

@QcFe QcFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@QcFe
Copy link
Collaborator

QcFe commented Nov 17, 2024

/merge

@kingmakerbot kingmakerbot merged commit 07e4a5a into netgroup-polito:master Nov 17, 2024
32 checks passed
@Mattia013 Mattia013 deleted the fix-delete-ssh-key-error branch November 17, 2024 11:18
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants