Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstanceSnapshot status validation #913

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

air-31
Copy link
Contributor

@air-31 air-31 commented Nov 6, 2024

This PR adds a kubebuilder validation marker for InstanceSnapshot CRD

@air-31 air-31 requested a review from a team as a code owner November 6, 2024 16:39
@kingmakerbot
Copy link
Collaborator

Hi @air-31. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@QcFe
Copy link
Collaborator

QcFe commented Nov 7, 2024

Thanks @air-31!
Just to be sure, I'd also add the empty string to the allowed values, as it is for instances.

@kingmakerbot
Copy link
Collaborator

The generated files in the operators/ folder appear to be out-of-date.

Please, ensure you are using the correct version of controller-gen and re-run:

make generate
make manifests
Here it is an excerpt of the diff:
diff --git a/operators/deploy/crds/crownlabs.polito.it_instancesnapshots.yaml b/operators/deploy/crds/crownlabs.polito.it_instancesnapshots.yaml%0Aindex b6e5cd8..9911de9 100644%0A--- a/operators/deploy/crds/crownlabs.polito.it_instancesnapshots.yaml%0A+++ b/operators/deploy/crds/crownlabs.polito.it_instancesnapshots.yaml%0A@@ -99,6 +99,7 @@ spec:%0A               phase:%0A                 description: Phase represents the current state of the Instance Snapshot.%0A                 enum:%0A+                - ""%0A                 - Pending%0A                 - Processing%0A                 - Completed

@air-31
Copy link
Contributor Author

air-31 commented Nov 13, 2024

@QcFe done! A week later, though...

@QcFe
Copy link
Collaborator

QcFe commented Nov 14, 2024

/merge

@kingmakerbot kingmakerbot merged commit 46049e2 into master Nov 14, 2024
32 checks passed
@kingmakerbot kingmakerbot deleted the ilkh/isnap-config branch November 14, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants