-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InstanceSnapshot status validation #913
Conversation
Hi @air-31. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
Thanks @air-31! |
ae0ab8d
to
d276c27
Compare
The generated files in the Please, ensure you are using the correct version of
Here it is an excerpt of the diff:diff --git a/operators/deploy/crds/crownlabs.polito.it_instancesnapshots.yaml b/operators/deploy/crds/crownlabs.polito.it_instancesnapshots.yaml%0Aindex b6e5cd8..9911de9 100644%0A--- a/operators/deploy/crds/crownlabs.polito.it_instancesnapshots.yaml%0A+++ b/operators/deploy/crds/crownlabs.polito.it_instancesnapshots.yaml%0A@@ -99,6 +99,7 @@ spec:%0A phase:%0A description: Phase represents the current state of the Instance Snapshot.%0A enum:%0A+ - ""%0A - Pending%0A - Processing%0A - Completed |
d276c27
to
ddfb930
Compare
@QcFe done! A week later, though... |
/merge |
This PR adds a kubebuilder validation marker for InstanceSnapshot CRD