Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HPE Proliant Microserver Gen10 & 11. Add HPE Proliant ML30 Gen10. #2554

Merged
merged 4 commits into from
Dec 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add HPE Proliant Microserver Gen10 & 11. Add HPE Proliant ML30 Gen10
celeroncool committed Dec 9, 2024
commit 0bc94d81ecbc5db2a7734d91d3323d0f63fafa92
28 changes: 28 additions & 0 deletions device-types/HPE/ProLiant-ML30-Gen10-plus.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
manufacturer: HPE
model: ProLiant ML30 Gen10 Plus
slug: proliant-ml30-gen10-plus
part_number: P44720-421
u_height: 4
is_full_depth: true
module-bays:
- name: PCIe1
position: PCIe1
- name: PCIe2
position: PCIe2
- name: PCIe3
position: PCIe3
- name: PCIe4
position: PCIe4
- name: PSU1
position: PSU1
- name: PSU2
position: PSU2
interfaces:
- name: Gig-E 1
type: 1000base-t
- name: Gig-E 2
type: 1000base-t
- name: iLO
type: 1000base-t
mgmt_only: true
25 changes: 25 additions & 0 deletions device-types/HPE/ProLiant-Microserver-Gen10.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
manufacturer: HPE
model: ProLiant MicroServer Gen10
slug: hpe-proliant-microserver-gen10
u_height: 0
is_full_depth: false
airflow: front-to-rear
weight: 6.5
weight_unit: kg
interfaces:
- name: Gig-E 1
type: 1000base-t
- name: Gig-E 2
type: 1000base-t
module-bays:
- name: PCIe1
position: PCIe1
- name: PCIe2
position: PCIe2
power-ports:
- name: PSU
type: iec-60320-c14
maximum_draw: 200
description: HPE ProLiant MicroServer Gen10
comments: '[PSnow: HPE ProLiant MicroServer Gen11](https://support.hpe.com/hpesc/public/docDisplay?docId=a00008701enw&docLocale=en_US)'
31 changes: 31 additions & 0 deletions device-types/HPE/ProLiant-Microserver-Gen11.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
manufacturer: HPE
model: ProLiant MicroServer Gen11
slug: hpe-proliant-microserver-gen11
u_height: 0
is_full_depth: false
airflow: front-to-rear
weight: 8.65
weight_unit: kg
interfaces:
- name: Gig-E 1
type: 1000base-t
- name: Gig-E 2
type: 1000base-t
- name: Gig-E 3
type: 1000base-t
- name: Gig-E 4
type: 1000base-t
module-bays:
- name: PCIe1
position: PCIe1
- name: PCIe2
position: PCIe2
- name: iLO/M.2/Serial port
position: 1
power-ports:
- name: PSU
type: dc-terminal
maximum_draw: 180
description: HPE ProLiant MicroServer Gen11
comments: '[PSnow: HPE ProLiant MicroServer Gen11](https://www.hpe.com/psnow/doc/PSN1014826370USEN.pdf?jumpid=in_pdp-psnow-dds)'

Unchanged files with check annotations Beta

validator.validate(definition)
except ValidationError as e:
# Schema validation failure. Ensure you are following the proper format.
pytest.fail(f"{file_path} failed validation: {e}", False)

Check failure on line 178 in tests/definitions_test.py

GitHub Actions / test

test_definitions[device-types/HPE/ProLiant-Microserver-Gen11.yaml-schema2-A] Failed: device-types/HPE/ProLiant-Microserver-Gen11.yaml failed validation: 1 is not of type 'string' Failed validating 'type' in schema['properties']['module-bays']['items']['properties']['position']: {'type': 'string'} On instance['module-bays'][2]['position']: 1
# Identify if the definition is for a Device or Module
if "device-types" in file_path:
# Verify the slug is valid, only if the definition type is a Device
if this_device.isDevice:
assert this_device.verify_slug(KNOWN_SLUGS), pytest.fail(this_device.failureMessage, False)

Check failure on line 190 in tests/definitions_test.py

GitHub Actions / test

test_definitions[device-types/HPE/ProLiant-ML30-Gen10-plus.yaml-schema0-A] Failed: device-types/HPE/ProLiant-ML30-Gen10-plus.yaml contains slug "proliant-ml30-gen10-plus". Does not start with manufacturer: "hpe-"
# Verify the filename is valid. Must either be the model or part_number.
assert verify_filename(this_device, (KNOWN_MODULES if not this_device.isDevice else None)), pytest.fail(this_device.failureMessage, False)