Fix attribute Type (for tenant and vlan_group) to Accept int only #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#985
New Behavior
Fix the related issue for the attributes tenant and vlan_group.
Contrast to Current Behavior
Changing the data type of the tenant and vlan_group attribute to integer to meet NetboxAPI standards.
It should not affect the current Behaviour, only fixes the related issue.
Discussion: Benefits and Drawbacks
This change will allow Ansible variables to be passed correctly using Jinja templating. For instance, with a variable tenantid initialized with the value 100, it can be passed as "tenant: {{ tenantid }}". Currently, Ansible would interpret is as a string and due to the parameter "raw" the module accept it as a string. With the propsed change, the module will convert/enforce the datatype to be an integer.
Discussion
There are several more attributes with the datatype "raw". It should be investigated whether these can be simplified to a specific datatype.
Changes to the Documentation
*[] Docs have been updated
Proposed Release Note Entry
Changing data type to meet NetboxAPI standards.