-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to measure separate timers per thread #3378
Open
JanVogelsang
wants to merge
14
commits into
nest:master
Choose a base branch
from
JanVogelsang:master-timers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thread synchronization time
JanVogelsang
added
S: Normal
Handle this with default priority
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
labels
Dec 9, 2024
heplesser
changed the title
Adding the option to measure separate timers per thread
Add the option to measure separate timers per thread
Dec 9, 2024
heplesser
reviewed
Dec 9, 2024
JanVogelsang
commented
Dec 9, 2024
heplesser
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JanVogelsang Thanks for the PR! Please look at my comments starting at the very end—I am wondering another approach that would avoid macros.
mlober
suggested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mlober
suggested changes
Dec 12, 2024
mlober
suggested changes
Dec 12, 2024
mlober
reviewed
Dec 13, 2024
…r into nest-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
S: Normal
Handle this with default priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to measure timers per thread and added timers to measure thread synchronization time. With this PR, we are hoping to be able to identify idle time of individual threads and identify black time present with the current timers.