Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add z_connected to values to be set for synaptic elements #3060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add z_connected to values to be set for synaptic elements #3060

wants to merge 1 commit into from

Conversation

ackurth
Copy link
Contributor

@ackurth ackurth commented Jan 2, 2024

The z_connected variables in synaptic elements in used to keep track of the connected synaptic elements, in contrast to the z variable that is used to determine how many connections ought to be established or deleted.
There are use cases when one wants to set z_connected by hand (for example when creating connections with a higher level connections routine that subsequently should be subject to potential removal by structural plasticity).
This PR add z_connected to the parameters that can be set by the user.

@ackurth ackurth changed the title Add to values to be set for synaptic elements Add z_connected to values to be set for synaptic elements Jan 2, 2024
@terhorstd terhorstd added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jan 19, 2024
heplesser
heplesser reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can follow the logic here. So far, z_connected_ is counted up or down as actual synapses are created. Setting this to some arbitrary value would break the consistency of the SynapticElement object, I fear.

@heplesser heplesser requested a review from jhnnsnk February 5, 2024 15:03
@clinssen
Copy link
Contributor

@ackurth: why could this not be done through calling SynapticElement::connect()?

@github-actions GitHub Actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Apr 22, 2024
@heplesser
Copy link
Contributor

@ackurth Could you respond to the comments above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser left review comments

@jhnnsnk jhnnsnk Awaiting requested review from jhnnsnk

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Enhancement New functionality, model or documentation
Projects
Models
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ackurth @clinssen @heplesser @terhorstd